feat: speedup ebpf uprobe attaching#440
Open
not-matthias wants to merge 4 commits into
Open
Conversation
Greptile SummaryThis PR speeds up memtrack eBPF allocator attachment. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (3): Last reviewed commit: "ci(memtrack): run offset resolution benc..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| 🆕 | Simulation | resolve_offsets_parallel |
N/A | 10.5 ms | N/A |
| 🆕 | Simulation | resolve_offsets_serial |
N/A | 10 ms | N/A |
Comparing cod-3070-speedup-allocator-attaching-on-nixos (9f32601) with main (eac7766)
not-matthias
force-pushed
the
cod-3070-speedup-allocator-attaching-on-nixos
branch
from
0e8688a to
3a322ae
Compare
…f func_name Resolve every defined symbol's libbpf-compatible file offset once per library (st_value - sh_addr + sh_offset) and attach uprobes by offset, replacing the per-probe func_name lookup that reparsed the ELF each time.
Symbol resolution parses each allocator ELF independently, so fan it out across cores with rayon before the serial attach step. Cuts offset resolution for all discovered allocators from ~190ms to ~29ms locally.
Divan bench comparing serial vs parallel symbol offset resolution over the discovered allocator libraries. Runs without sudo since it only parses ELFs, no eBPF attach.
not-matthias
force-pushed
the
cod-3070-speedup-allocator-attaching-on-nixos
branch
from
3a322ae to
9f32601
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.